Request 4217 (accepted)

We truncated the diff of some files because they were too big. If you want to see the full diff for every file, click here.

Overview

Request 4217 (accepted)

Update and fix. Will require linking perl-CDDB and perl-Parallel-ForkManager from devel:languages:perl .

Created by Aloysius almost 8 years ago
In state accepted

Submit pacpl

Submit package home:Aloysius:branches:Multimedia / pacpl to package Multimedia / pacpl

pacpl.changes Changed

pacpl.spec Changed

@@ -1,23 +1,32 @@
 #
 # spec file for package pacpl
 #
+# Copyright (c) 2018 Packman Team <packman@links2linux.de>
 # Copyright (c) 2011-2012 Malcolm J Lewis <malcolmlewis@opensuse.org>
 #
-# This file and all modifications and additions to the pristine
-# package are under the same license as the package itself.
+# All modifications and additions to the file contributed by third parties
+# remain the property of their copyright owners, unless otherwise agreed
+# upon. The license for this file, and modifications and additions to the
+# file, is the same license as for the pristine package itself (unless the
+# license for the pristine package is not an Open Source License, in which
+# case the license is the MIT License). An "Open Source License" is a
+# license that conforms to the Open Source Definition (Version 1.9)
+# published by the Open Source Initiative.
+
+# Please submit bugfixes or comments via http://bugs.links2linux.org/
 #
 
+
 Name:           pacpl
-Version:        4.0.5
-Release:        1
-License:        GPL-3.0
+Version:        5.1.0
+Release:        0
 Summary:        A tool to convert audio files between many different types
-Url:            http://sourceforge.net/projects/pacpl
+License:        GPL-3.0
 Group:          Productivity/Multimedia/Sound/Editors and Convertors
-Source0:        http://iweb.dl.sourceforge.net/project/pacpl/pacpl/4.0.5/pacpl-4.0.5.tar.gz
+URL:            http://sourceforge.net/projects/pacpl
+Source0:        https://sourceforge.net/projects/pacpl/files/pacpl/%{version}/pacpl-%{version}.tar.gz
 # PATCH-FIX-OPENSUSE pacpl-fix-docs-and-paths.patch malcolmlewis@opensuse.org -- Fix docdir and kde4 directory paths, add missing ChangeLog and COPYING
 Patch0:         pacpl-fix-docs-and-paths.patch
-
 BuildRequires:  perl(Audio::APETags)
 BuildRequires:  perl(Audio::FLAC::Header)
 BuildRequires:  perl(Audio::Musepack)
@@ -30,10 +39,33 @@
 BuildRequires:  perl(MP3::Tag)
 BuildRequires:  perl(MP4::Info)
 BuildRequires:  perl(Ogg::Vorbis::Header)
+BuildRequires:  perl(Parse::RecDescent)
+BuildRequires:  perl(Devel::Symdump)
+BuildRequires:  perl(Pod::Coverage)
+BuildRequires:  perl(Parallel::ForkManager)
+BuildRequires:  perl(Test::Pod::Coverage)
+BuildRequires:  perl(Audio::Scan)
+BuildRequires:  perl(MP3::Info)
+BuildRequires:  perl(IO::String)
+BuildRequires:  perl(CDDB)
 BuildRequires:  perl(Switch)
 BuildRequires:  perl(strict)
 BuildRequires:  perl(warnings)
-
+Requires:       perl(Audio::APETags)
+Requires:       perl(Audio::FLAC::Header)
+Requires:       perl(Audio::Musepack)
+Requires:       perl(Audio::WMA)
+Requires:       perl(CDDB_get)
+Requires:       perl(File::Basename)
+Requires:       perl(File::Find)
+Requires:       perl(File::Spec::Functions)
+Requires:       perl(Getopt::Long)
+Requires:       perl(MP3::Tag)
+Requires:       perl(MP4::Info)
+Requires:       perl(Ogg::Vorbis::Header)
+Requires:       perl(Switch)
+Requires:       perl(strict)
+Requires:       perl(warnings)
 Recommends:     bonk
 Recommends:     cdparanoia
 Recommends:     faac
@@ -50,22 +82,6 @@
 Recommends:     ttaenc
 Recommends:     vorbis-tools
 Recommends:     wavpack
-Requires:       perl(Audio::APETags)
-Requires:       perl(Audio::FLAC::Header)
-Requires:       perl(Audio::Musepack)
-Requires:       perl(Audio::WMA)
-Requires:       perl(CDDB_get)
-Requires:       perl(File::Basename)
-Requires:       perl(File::Find)
-Requires:       perl(File::Spec::Functions)
-Requires:       perl(Getopt::Long)
-Requires:       perl(MP3::Tag)
-Requires:       perl(MP4::Info)
-Requires:       perl(Ogg::Vorbis::Header)
-Requires:       perl(Switch)
-Requires:       perl(strict)
-Requires:       perl(warnings)
-BuildRoot:      %{_tmppath}/%{name}-%{version}-build
 BuildArch:      noarch
 
 %description
@@ -80,52 +96,53 @@
 and  playlist conversion, tag preservation for most supported formats,
 independent  tag  reading/writing.
 
-%package -n kde4-%{name}-plugins
-Summary:        KDE4 plugins
+%package -n kf5-%{name}-plugins
+Summary:        KF5 plugins
 Group:          Productivity/Multimedia/Sound/Editors and Convertors
-BuildRequires:  amarok
-BuildRequires:  dolphin
-BuildRequires:  kdebase4-workspace-devel
 BuildRequires:  kdialog
-BuildRequires:  konqueror
+BuildRequires:  kf5-filesystem
 BuildRequires:  update-desktop-files
 Requires:       %{name}
-%kde4_runtime_requires
+Requires:       kf5-filesystem
 
-%description -n kde4-%{name}-plugins
+%description -n kf5-%{name}-plugins
 Provides a plugin for amaroK and service menus for Dolphin and
 Konqueror.
 
 %prep
 %setup -q
-%patch0
+%patch0 -p1
+sed -e '/^Icon/cIcon=%{name}' -e '/^Exec/cExec=PACPL-Konvert' \
+    -i plugins/kde/pacpl.desktop
+sed -e '/EXTRA/d' -i Makefile.in
 
 %build
 %configure
 make %{?_smp_mflags}
 
 %install
-%makeinstall
-%suse_update_desktop_file %{buildroot}%{_kde_share_dir}/services/pacpl.desktop
-
-%clean
-rm -rf '%{buildroot}'
+%make_install
+rm -f %{buildroot}%{_sysconfdir}/%{name}/pacpl.png \
+      %{buildroot}%{_defaultdocdir}/%{name}/INSTALL
+install -m0644 extra/README.module extra/sample.m -t %{buildroot}%{_defaultdocdir}/%{name}
+install -D -m0644 pacpl.png %{buildroot}%{_datadir}/pixmaps/%{name}.png
+install -m0755 plugins/kde/PACPL-Konvert -t %{buildroot}%{_bindir}
+install -D -m0644 plugins/kde/pacpl.desktop %{buildroot}%{_kf5_servicesdir}/%{name}.desktop
+%suse_update_desktop_file %{buildroot}%{_kf5_servicesdir}/%{name}.desktop
 
 %files
-%defattr(-,root,root)
 %{_bindir}/%{name}
-%{_datadir}/%{name}/
-%doc %{_docdir}/%{name}/
-%{_mandir}/man1/*.gz
+%{_datadir}/%{name}
+%doc %{_docdir}/%{name}
+%{_mandir}/man1/*%{ext_man}
 %dir %{_sysconfdir}/%{name}
 %dir %{_sysconfdir}/%{name}/modules
 %config %{_sysconfdir}/%{name}/codecs.conf
 %config %{_sysconfdir}/%{name}/pacpl.conf
-%config %{_sysconfdir}/%{name}/modules/sample.m
 
-%files -n kde4-%{name}-plugins
-%defattr(-,root,root)
-%{_kde_share_dir}/services/pacpl.desktop
-%{_kde_share_dir}/apps/amarok
+%files -n kf5-%{name}-plugins
+%{_bindir}/PACPL-Konvert
+%{_datadir}/pixmaps/%{name}.png
+%{_kf5_servicesdir}/%{name}.desktop
 
 %changelog

pacpl-fix-docs-and-paths.patch Changed

@@ -1,6 +1,8 @@
---- configure	2011-07-08 10:44:07.000000000 -0500
-+++ configure.orig	2011-07-08 10:44:41.000000000 -0500
-@@ -737,7 +737,7 @@
+Index: pacpl-5.1.0/configure
+===================================================================
+--- pacpl-5.1.0.orig/configure
++++ pacpl-5.1.0/configure
+@@ -760,7 +760,7 @@ sharedstatedir='${prefix}/com'
  localstatedir='${prefix}/var'
  includedir='${prefix}/include'
  oldincludedir='/usr/include'
@@ -9,23 +11,3 @@
  infodir='${datarootdir}/info'
  htmldir='${docdir}'
  dvidir='${docdir}'
---- Makefile.in	2009-03-19 22:24:18.000000000 -0500
-+++ Makefile.in.orig	2011-07-08 12:31:10.000000000 -0500
-@@ -28,7 +28,7 @@
- # Modules & Documentation
- #
- 
--DOCS = README AUTHORS TODO
-+DOCS = AUTHORS ChangeLog COPYING README TODO
- 
- LANG_MODS = po/ca.po \
- 	    po/de.po \
-@@ -73,7 +73,7 @@
- KONQ_PLUGDIR   = $(DESTDIR)$(KDEDIR)/share/kde4/services
- DOLP_PLUGDIR   = $(DESTDIR)$(KDEDIR)/share/kde4/services
- D3LP_PLUGDIR   = $(DESTDIR)$(KDEDIR)/share/apps/d3lphin/servicemenus
--AMAROK_PLUGDIR = $(DESTDIR)$(KDEDIR)/share/apps/amarok/scripts/pacx
-+AMAROK_PLUGDIR = $(DESTDIR)$(KDEDIR)/share/kde4/apps/amarok/scripts/pacx
- 
- #
- # Compiler tools definitions...

pacpl-4.0.5.tar.gz -> pacpl-5.1.0.tar.gz Changed

Build Results
RPM Lint

Refresh

Comments for request 4217 0

Request History

Aloysius created request almost 8 years ago

Update and fix. Will require linking perl-CDDB and perl-Parallel-ForkManager from devel:languages:perl .

olh accepted request almost 8 years ago