Request 1002 (accepted)

Overview

Request 1002 (accepted)

- faad2-visibility.patch Only public symbols should be
exported + fix broken C99 test

Created by crrodriguez about 10 years ago
In state accepted
Package maintainers: detrei and mantre

Submit faad2

Submit package home:crrodriguez...nches:Essentials / faad2 to package Essentials / faad2

faad2.changes Changed

faad2.spec Changed

faad2-visibility.patch Added

@@ -0,0 +1,91 @@
+--- faad2-2.7.orig/include/neaacdec.h
++++ faad2-2.7/include/neaacdec.h
+@@ -31,6 +31,8 @@
+ #ifndef __NEAACDEC_H__
+ #define __NEAACDEC_H__
+ 
++#pragma GCC visibility push(default)
++
+ #ifdef __cplusplus
+ extern "C" {
+ #endif /* __cplusplus */
+@@ -254,5 +256,5 @@ char NEAACDECAPI NeAACDecAudioSpecificCo
+ #ifdef __cplusplus
+ }
+ #endif /* __cplusplus */
+-
++#pragma GCC visibility pop
+ #endif
+--- faad2-2.7.orig/libfaad/Makefile.am
++++ faad2-2.7/libfaad/Makefile.am
+@@ -1,10 +1,10 @@
+ lib_LTLIBRARIES = libfaad.la
+ 
+-AM_CFLAGS	= -iquote $(top_srcdir)/include
++AM_CFLAGS	= -fvisibility=hidden -iquote $(top_srcdir)/include
+ include_HEADERS = $(top_srcdir)/include/faad.h \
+ 		  $(top_srcdir)/include/neaacdec.h
+ 
+-libfaad_la_LDFLAGS = -version-info 2:0:0
++libfaad_la_LDFLAGS = -no-undefined -version-info 2:0:0
+ libfaad_la_LIBADD = -lm
+ 
+ libfaad_la_SOURCES = bits.c cfft.c decoder.c drc.c \
+--- faad2-2.7.orig/configure.in
++++ faad2-2.7/configure.in
+@@ -15,7 +15,9 @@ AC_PROG_LIBTOOL
+ AC_SUBST(LIBTOOL_DEPS)
+ 
+ dnl Checks for programs.
+-AC_PROG_CC
++AC_PROG_CC_STDC
++AC_USE_SYSTEM_EXTENSIONS
++AC_SYS_LARGEFILE
+ AM_PROG_CC_C_O
+ AC_PROG_CPP
+ dnl disable for mpeg4ip plugin
+@@ -74,43 +76,7 @@ AC_DEFUN([MY_CHECK_TYPEDEF_FROM_INCLUDE]
+ fi
+ ])
+ 
+-dnl @synopsis AC_C99_FUNC_LRINTF
+-dnl
+-dnl Check whether C99's lrintf function is available.
+-dnl @version 1.3        Feb 12 2002
+-dnl @author Erik de Castro Lopo <erikd AT mega-nerd DOT com>
+-dnl
+-dnl Permission to use, copy, modify, distribute, and sell this file for any
+-dnl purpose is hereby granted without fee, provided that the above copyright
+-dnl and this permission notice appear in all copies.  No representations are
+-dnl made about the suitability of this software for any purpose.  It is
+-dnl provided "as is" without express or implied warranty.
+-dnl
+-AC_DEFUN([AC_C99_FUNC_LRINTF],
+-[AC_CACHE_CHECK(for lrintf,
+-  ac_cv_c99_lrintf,
+-[
+-lrintf_save_CFLAGS=$CFLAGS
+-CFLAGS="-O -lm"
+-AC_TRY_LINK([
+-#define         _ISOC9X_SOURCE  1
+-#define         _ISOC99_SOURCE  1
+-#define         __USE_ISOC99    1
+-#define         __USE_ISOC9X    1
+-
+-#include <math.h>
+-], if (!lrintf(3.14159)) lrintf(2.7183);, ac_cv_c99_lrintf=yes, ac_cv_c99_lrintf=no)
+-
+-CFLAGS=$lrintf_save_CFLAGS
+-
+-])
+-
+-if test "$ac_cv_c99_lrintf" = yes; then
+-  AC_DEFINE(HAVE_LRINTF, 1,
+-            [Define if you have C99's lrintf function.])
+-fi
+-])# AC_C99_FUNC_LRINTF
+-AC_C99_FUNC_LRINTF
++AC_SEARCH_LIBS([lrintf], [m], [AC_DEFINE([HAVE_LRINTF], [1], [Define if you have C99 lrintf function])])
+ 
+ MY_CHECK_TYPEDEF_FROM_INCLUDE([float32_t temp],
+         [#include <sys/types.h>,

Build Results
RPM Lint

Refresh

Comments for request 1002 0

Request History

crrodriguez created request about 10 years ago

- faad2-visibility.patch Only public symbols should be
exported + fix broken C99 test

mantre accepted request about 10 years ago

good work